Playmaker Forum

Bug Reporting => PlayMaker Bug Reporting => Topic started by: djaydino on August 27, 2016, 06:29:03 PM

Title: Get Child Action Tag problem and other Action Tag issues
Post by: djaydino on August 27, 2016, 06:29:03 PM

Hi,
The Get Child Action Does not work as expected :

i have child objects with the same name but different tags used for something else so i tried to get them by setting "With Tag" to none but that did not work.

Title: Re: Get Child Action problem
Post by: jeanfabre on September 06, 2016, 03:05:45 AM

Hi,

 odd. Can you make a quick repo scene, and I'll have a look and debug the code. Thanks :)

 Bye,

 Jean

Title: Re: Get Child Action problem
Post by: djaydino on September 06, 2016, 05:56:01 AM

Hi,
It is very simple just make an object and place a child in it with a tag on it
the use get child, set the child name then on the with tag press the = to set to none.

But i just noticed when i press = again, it will show an empty bar and then it seems to work.
the script is not checking if the tag is null or empty and i made a solution already but i think this should be updated on the official action :)

Title: Re: Get Child Action problem
Post by: jeanfabre on September 26, 2016, 04:46:24 AM

Hi,

 I am not sure I follow actually :) can you make a screencast? I'd like to get to the bottom of this. If there is a problem, we need to fix it.

 Bye,

 Jean

Title: Re: Get Child Action problem
Post by: djaydino on September 26, 2016, 06:27:30 PM

Hi,
I made a quick video :

(unity version 5.4.1f1 PM version 1.8.3f4)

Title: Re: Get Child Action problem
Post by: jeanfabre on September 27, 2016, 03:22:18 AM

Hi,

 yes I see. It's known misunderstanding.

Basically "untagged" means that no tag is set on the gameobject, it's not the same as allowing any tags, or to say this otherwise, ignoring tags all together. For this indeed set it to none or empty as you did.

It's tricky to change this right now as existing projects relies on this and so modifying this to ignore tags by default would corrupt existing projects.

Bye,

 Jean

Title: Re: Get Child Action problem
Post by: djaydino on September 27, 2016, 11:51:29 AM

Hi,
Is this also the reason that when set to none sometimes works and sometimes not when playing around with the settings, like i did on the video?

Title: Re: Get Child Action problem
Post by: jeanfabre on October 10, 2016, 05:23:57 AM

Hi,

 the behaviour is consistent.

 "none" means that any tag can be on the gameobject
 "untagged" means that no tag must be on the gameobject

then depending on how you setup the action interface, you fall into one of the case above.

 Bye,

 Jean

Title: Re: Get Child Action problem
Post by: djaydino on October 10, 2016, 08:18:12 PM

Hi,

Quote

"none" means that any tag can be on the gameobject

if you look closely to the video it does not find the child on the 1st time.

Then when i press the = again i get a blanco selection and then it works.

After that i did this and pressed the = again, then it works on 'none'

Title: Re: Get Child Action problem
Post by: jeanfabre on October 11, 2016, 05:13:40 AM

Hi,

 I see sorry, I know what's the problem now. I have fixed it. I'll see with Alex if it should make it in an update or stay as is, because it will potentially break existing projects

Thanks for your patience :)

 Bye,

 Jean

Title: Re: Get Child Action problem
Post by: djaydino on October 11, 2016, 09:14:26 AM

Hi,
No problem.
I do think this should be changed, maybe with a big warning when updating :)

Title: Re: Get Child Action problem
Post by: jeanfabre on October 14, 2016, 02:40:01 AM

Hi,

 This is a serious bug indeed as it corrupts the logic 'none' should not return a previous value setup on that action, it should return an empty string.

Bye,

 Jean

Title: Re: Get Child Action Tag problem and other Action Tag issues
Post by: djaydino on October 16, 2016, 08:47:27 AM

Hi,
I was testing something for someone on the forum and i found out that on the "Collision Event" Action the tag set to none or empty does not work at all.
Should i look on other actions and send a bug report in PM for each one i found with this problem?

Title: Re: Get Child Action Tag problem and other Action Tag issues
Post by: jeanfabre on October 25, 2016, 02:03:56 AM

Hi,

 yes if you can do this, that would be good, then we can do a batch update to fix them.

thanks,

 Bye,

 Jean