Playmaker Forum

Bug Reporting => PlayMaker Bug Reporting => Topic started by: NateGallardo on November 22, 2016, 06:30:51 AM

Title: Datamaker XML - Flickering
Post by: NateGallardo on November 22, 2016, 06:30:51 AM
Hello!

Certain configurations of the Datamaker XML actions result in some crazy GUI flickering that makes it impossible to use.

Specifically, the XML Select Nodes action, using the 'Use Variable' Source Selection option.


Here's a video:
https://drive.google.com/open?id=0B0O4KrfsmB-PUG9TT0Z1RVlCX0k

It also spams a whole host of error messages, as in the attached image.

Unity 5.4.0f3
Playmaker 1.8.2f7
Datamaker 1.2
Title: Re: Datamaker XML - Flickering
Post by: jeanfabre on November 24, 2016, 12:17:35 AM
Hi,

 I see, the content of the string is too much for the UI to cope and show that much text.

I'll see what I can do and provide a fix asap.

Bye,

 Jean
Title: Re: Datamaker XML - Flickering
Post by: jeanfabre on November 24, 2016, 12:31:30 AM
Hi,

 odd, I can't repro here. I can crash the editor if I put a 30 Mb xml but the UI went well. maybe you could pm me if I Can take a look at your project, I'll be able to repro and fix it.

 Bye,

 Jean
Title: Re: Datamaker XML - Flickering
Post by: NateGallardo on November 27, 2016, 11:59:24 PM
Hi Jean!

Thanks for looking into it. I am currently out of the country for a few weeks, but I'll set myself a reminder to send it over to you when I'm back in the UK!

Cheers
Title: Re: Datamaker XML - Flickering
Post by: jeanfabre on November 28, 2016, 01:18:26 AM
Hi,

 cool, no worries.

 I found the issue, it's just my bad I though I leverage updates from one project to another and I did not... so know long xml string will be edited out to avoid flickering.

ping me when you are back on this.

 Bye,

 Jean
Title: Re: Datamaker XML - Flickering
Post by: NateGallardo on January 17, 2017, 07:45:09 AM
*ping* I'm back on this!
Title: Re: Datamaker XML - Flickering
Post by: jeanfabre on January 18, 2017, 11:26:20 PM
cool :)

 can you confirm flickering is gone, I updated the code to prevent this.

 Bye,

 Jean
Title: Re: Datamaker XML - Flickering
Post by: NateGallardo on January 23, 2017, 04:12:01 AM
I've just updated Datamaker via the ecosystem to check this fix, but I'm still very much experiencing the flickering:

https://drive.google.com/open?id=0BzXgDZLN7B3KeXo5UG5fZnhHUlk

These errors in the attached image are spammed during the flickering.

Title: Re: Datamaker XML - Flickering
Post by: jeanfabre on January 23, 2017, 11:03:21 PM
Hi,

 uhm, ok, could you share with me this project? I can sign an nda of course.

 Bye,

 Jean
Title: Re: Datamaker XML - Flickering
Post by: NateGallardo on January 24, 2017, 05:00:11 AM
Hey Jean,

The main project is huge, so I'll see about getting git access, but for now here's a new project where the same behaviour can be seen:

https://drive.google.com/file/d/0BzXgDZLN7B3KZVZtN2ZrbTkzeDg/view?usp=sharing
Title: Re: Datamaker XML - Flickering
Post by: NateGallardo on January 24, 2017, 08:15:48 AM
Hey Jean,

I've been able to narrow down the conditions under which the flickering occurs.

1) It's specific to the XML Select Node, XML Select Nodes and XML Select Single Node actions. It may occur on other actions too, but these are the only ones I've seen it happen on.

2) It only happens on my Windows 10 machine, it doesn't happen on OSX!

3) It only happens when I have the Action Browser open!

I hope that helps.
Title: Re: Datamaker XML - Flickering
Post by: jeanfabre on January 25, 2017, 11:34:19 PM
Hi,

 oh woah... ok, I'll investigate. is it the preview? what if you close the preview section?

Bye,

 Jean
Title: Re: Datamaker XML - Flickering
Post by: NateGallardo on January 26, 2017, 10:04:24 AM
It even happens with the preview collapsed/hidden. It doesn't happen if I collapse the action itself.

Can now confirm it also happens with XML Get Node Properties, using the combination as shown in the attached images. The first image is the action when it is displaying properly and the second shows how the action and the editor looks when it glitches.

Here are the main errors that spam the console during the glitching:

Code: [Select]
ArgumentException: Getting control 1's position in a group with only 1 controls when doing Repaint
Aborting
UnityEngine.GUILayoutGroup.GetNext () (at C:/buildslave/unity/build/Runtime/IMGUI/Managed/GUILayoutUtility.cs:665)
UnityEngine.GUILayoutUtility.DoGetRect (UnityEngine.GUIContent content, UnityEngine.GUIStyle style, UnityEngine.GUILayoutOption[] options) (at C:/buildslave/unity/build/Runtime/IMGUI/Managed/GUILayoutUtility.cs:372)
UnityEngine.GUILayoutUtility.GetRect (UnityEngine.GUIContent content, UnityEngine.GUIStyle style, UnityEngine.GUILayoutOption[] options) (at C:/buildslave/unity/build/Runtime/IMGUI/Managed/GUILayoutUtility.cs:332)
UnityEditor.EditorGUILayout.LabelField (UnityEngine.GUIContent label, UnityEngine.GUIContent label2, UnityEngine.GUIStyle style, UnityEngine.GUILayoutOption[] options) (at C:/buildslave/unity/build/Editor/Mono/EditorGUI.cs:5437)
UnityEditor.EditorGUILayout.HelpBox (System.String message, MessageType type) (at C:/buildslave/unity/build/Editor/Mono/EditorGUI.cs:6833)
HutongGames.PlayMakerEditor.StateInspector.DoActionsListGUI (HutongGames.PlayMaker.FsmState state) (at c:/Users/Alex/Documents/Unity/Playmaker/Projects/Playmaker.source.unity/Assets/PlayMaker/Editor/Classes/StateInspector.cs:451)
HutongGames.PlayMakerEditor.StateInspector.DoActionsPanel () (at c:/Users/Alex/Documents/Unity/Playmaker/Projects/Playmaker.source.unity/Assets/PlayMaker/Editor/Classes/StateInspector.cs:327)
HutongGames.PlayMakerEditor.StateInspector.OnGUI () (at c:/Users/Alex/Documents/Unity/Playmaker/Projects/Playmaker.source.unity/Assets/PlayMaker/Editor/Classes/StateInspector.cs:200)
HutongGames.PlayMakerEditor.InspectorPanel.OnGUI (Rect area) (at c:/Users/Alex/Documents/Unity/Playmaker/Projects/Playmaker.source.unity/Assets/PlayMaker/Editor/Classes/InspectorPanel.cs:164)
HutongGames.PlayMakerEditor.FsmEditor.OnGUI () (at c:/Users/Alex/Documents/Unity/Playmaker/Projects/Playmaker.source.unity/Assets/PlayMaker/Editor/Classes/FsmEditor.cs:539)
HutongGames.PlayMakerEditor.FsmEditorWindow.DoGUI () (at Assets/PlayMaker/Editor/FsmEditorWindow.cs:95)
HutongGames.PlayMakerEditor.BaseEditorWindow.OnGUI () (at c:/Users/Alex/Documents/Unity/Playmaker/Projects/Playmaker.source.unity/Assets/PlayMaker/Editor/Classes/BaseEditorWindow.cs:72)
System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Reflection/MonoMethod.cs:222)

Code: [Select]
ArgumentException: GUILayout: Mismatched LayoutGroup.Repaint
UnityEngine.GUILayoutUtility.BeginLayoutGroup (UnityEngine.GUIStyle style, UnityEngine.GUILayoutOption[] options, System.Type layoutType) (at C:/buildslave/unity/build/Runtime/IMGUI/Managed/GUILayoutUtility.cs:273)
UnityEditor.EditorGUILayout.BeginHorizontal (UnityEngine.GUIContent content, UnityEngine.GUIStyle style, UnityEngine.GUILayoutOption[] options) (at C:/buildslave/unity/build/Editor/Mono/EditorGUI.cs:6970)
UnityEditor.EditorGUILayout.BeginHorizontal (UnityEngine.GUILayoutOption[] options) (at C:/buildslave/unity/build/Editor/Mono/EditorGUI.cs:6949)
UnityEditor.EditorGUILayout.LabelField (UnityEngine.GUIContent label, UnityEngine.GUIContent label2, UnityEngine.GUIStyle style, UnityEngine.GUILayoutOption[] options) (at C:/buildslave/unity/build/Editor/Mono/EditorGUI.cs:5435)
UnityEditor.EditorGUILayout.HelpBox (System.String message, MessageType type) (at C:/buildslave/unity/build/Editor/Mono/EditorGUI.cs:6833)
HutongGames.PlayMakerEditor.StateInspector.DoActionsListGUI (HutongGames.PlayMaker.FsmState state) (at c:/Users/Alex/Documents/Unity/Playmaker/Projects/Playmaker.source.unity/Assets/PlayMaker/Editor/Classes/StateInspector.cs:451)
HutongGames.PlayMakerEditor.StateInspector.DoActionsPanel () (at c:/Users/Alex/Documents/Unity/Playmaker/Projects/Playmaker.source.unity/Assets/PlayMaker/Editor/Classes/StateInspector.cs:327)
HutongGames.PlayMakerEditor.StateInspector.OnGUI () (at c:/Users/Alex/Documents/Unity/Playmaker/Projects/Playmaker.source.unity/Assets/PlayMaker/Editor/Classes/StateInspector.cs:200)
HutongGames.PlayMakerEditor.InspectorPanel.OnGUI (Rect area) (at c:/Users/Alex/Documents/Unity/Playmaker/Projects/Playmaker.source.unity/Assets/PlayMaker/Editor/Classes/InspectorPanel.cs:164)
HutongGames.PlayMakerEditor.FsmEditor.OnGUI () (at c:/Users/Alex/Documents/Unity/Playmaker/Projects/Playmaker.source.unity/Assets/PlayMaker/Editor/Classes/FsmEditor.cs:539)
HutongGames.PlayMakerEditor.FsmEditorWindow.DoGUI () (at Assets/PlayMaker/Editor/FsmEditorWindow.cs:95)
HutongGames.PlayMakerEditor.BaseEditorWindow.OnGUI () (at c:/Users/Alex/Documents/Unity/Playmaker/Projects/Playmaker.source.unity/Assets/PlayMaker/Editor/Classes/BaseEditorWindow.cs:72)
System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at /Users/builduser/buildslave/mono/build/mcs/class/corlib/System.Reflection/MonoMethod.cs:222)