playMaker

Author Topic: IndexOutOfRangeException when loading prefab containing PlayMaker FSM  (Read 584 times)

RiverNyxx

  • Playmaker Newbie
  • *
  • Posts: 6
I'm working in a very large code base that contains a variety of (Unity-provided) async loading for various assets, including prefabs that contain somewhere in them one or more PlayMaker FSMs.

Some of our automated exception reports from our live product show the following truncated stack trace for an IndexOutOfRangeException:
Code: [Select]
System.Collections.Generic.Dictionary`2[TKey,TValue].TryInsert (TKey key, TValue value, System.Collections.Generic.InsertionBehavior behavior) (at <7ba07f088431485bb722f3b3373e87ee>:0)
System.Collections.Generic.Dictionary`2[TKey,TValue].set_Item (TKey key, TValue value) (at <7ba07f088431485bb722f3b3373e87ee>:0)
HutongGames.PlayMaker.ActionData.GetActionTypeHashCode (System.Type actionType) (at <7e9e696ff1a04620968849cd9bbf2ab4>:0)
HutongGames.PlayMaker.ActionData.CreateAction (HutongGames.PlayMaker.ActionData+Context context, System.Int32 actionIndex) (at <7e9e696ff1a04620968849cd9bbf2ab4>:0)
HutongGames.PlayMaker.ActionData.LoadActions (HutongGames.PlayMaker.FsmState state) (at <7e9e696ff1a04620968849cd9bbf2ab4>:0)
HutongGames.PlayMaker.FsmState.LoadActions () (at <7e9e696ff1a04620968849cd9bbf2ab4>:0) HutongGames.PlayMaker.Fsm.InitData () (at <7e9e696ff1a04620968849cd9bbf2ab4>:0)
PlayMakerFSM.OnAfterDeserialize () (at <7e9e696ff1a04620968849cd9bbf2ab4>:0)
UnityEngine.AssetBundle:LoadAsset(String, Type)
...

The only reason I can think of that a Dictionary would throw an IndexOutOfRangeException during an insert is due to a race condition with multiple inserts from different threads around the same time. It appears that this really is possible in PlayMaker, since ActionData.ActionHashCodeLookup (and some others) are static members, and susceptible to race conditions in this very manner.

Consider the above a bug report. Below, a request for how I might deal with/work around this:

Ideally, this would be fixed inside PlayMaker itself. It's the most logical/clean place for it, but since everything is contained inside a .DLL, such changes cannot be made by us.

While waiting for an update that includes such a bug fix, my first thought was to introduce some locking pattern for thread safety inside our loading code, but we don't want to force all loading to use this pattern, as it would effectively turn the async loading into something not far off of sync loading. It's only necessary for loading levels/prefabs/etc containing PlayMaker FSMs.

Any thoughts on how I might avoid this without incurring a significant loss of async loading performance?

djaydino

  • Administrator
  • Hero Member
  • *****
  • Posts: 7086
    • jinxtergames
Re: IndexOutOfRangeException when loading prefab containing PlayMaker FSM
« Reply #1 on: August 10, 2022, 11:57:13 PM »
Hi.
does this asset bundle contain reference to new actions?
if so you need to update the main Asset/game as they will not be included in the asset bundle (or playmaker cant find them)

RiverNyxx

  • Playmaker Newbie
  • *
  • Posts: 6
Re: IndexOutOfRangeException when loading prefab containing PlayMaker FSM
« Reply #2 on: August 11, 2022, 12:21:52 PM »
Hi.
Sorry, I didn't specifically call this out -- as far as I've been able to see, this exception doesn't happen every time. It's actually quite rare to happen. That tells me that it often DOES work just fine, so I believe it's not an issue with an AssetBundle being out of sync with the main asset/game.

Also, correct me if I'm wrong here, but I believe you may be implying here that the exception I'm encountering is a KeyNotFoundException, which would occur when trying to retrieve a KeyValuePair from a Dictionary using a key that doesn't exist in it? However, that's not the exception I'm getting -- I'm getting an IndexOutOfRangeException, and it's occurring when trying to ADD a KeyValuePair to the Dictionary, as the stack trace shows.

djaydino

  • Administrator
  • Hero Member
  • *****
  • Posts: 7086
    • jinxtergames
Re: IndexOutOfRangeException when loading prefab containing PlayMaker FSM
« Reply #3 on: August 11, 2022, 11:04:44 PM »
Hi.
I will ping Alex to have a look (he's the creator of Playmaker) .

RiverNyxx

  • Playmaker Newbie
  • *
  • Posts: 6
Re: IndexOutOfRangeException when loading prefab containing PlayMaker FSM
« Reply #4 on: August 12, 2022, 11:58:35 AM »
Thanks!
Looking forward to hearing about this :)

Alex Chouls

  • Administrator
  • Hero Member
  • *****
  • Posts: 3967
  • Official Playmaker Support
    • LinkedIn
Re: IndexOutOfRangeException when loading prefab containing PlayMaker FSM
« Reply #5 on: August 13, 2022, 12:27:21 AM »
Hi, I have a build that should fix this. Do you have a way to reproduce the error, to check if the build fixes the issue? PM me so we can get you the build to test.

RiverNyxx

  • Playmaker Newbie
  • *
  • Posts: 6
Re: IndexOutOfRangeException when loading prefab containing PlayMaker FSM
« Reply #6 on: August 16, 2022, 12:48:41 PM »
Good morning,
Unfortunately, I don't have a consistent/reliable way to reproduce this -- all of our attempts to reproduce in a dev environment have failed, but we're getting the exception reported sometimes from our live product.
I fear that my leads will be hesitant to integrate another PlayMaker update so quickly after we'd already done one -- we'd done an update just a few months ago.
While I analyze risk on this, do you have any thoughts about how this might be addressed in our own code with minimal effect to our loading performance?

Alex Chouls

  • Administrator
  • Hero Member
  • *****
  • Posts: 3967
  • Official Playmaker Support
    • LinkedIn
Re: IndexOutOfRangeException when loading prefab containing PlayMaker FSM
« Reply #7 on: August 16, 2022, 02:30:23 PM »
What version of PlayMaker did you ship with?

RiverNyxx

  • Playmaker Newbie
  • *
  • Posts: 6
Re: IndexOutOfRangeException when loading prefab containing PlayMaker FSM
« Reply #8 on: August 16, 2022, 04:02:38 PM »
The current version that is shipped is using PlayMaker 1.9.4.f2
I'm assuming this new build of yours is built on top of the last public release (1.9.5.f3)?
If so, looking at the changelog with my lead, it seems we will be willing to take on the update.
« Last Edit: August 16, 2022, 04:25:20 PM by RiverNyxx »

RiverNyxx

  • Playmaker Newbie
  • *
  • Posts: 6
Re: IndexOutOfRangeException when loading prefab containing PlayMaker FSM
« Reply #9 on: September 13, 2022, 12:18:15 PM »
Hey, just following up on this, as I haven't heard anything in this thread for a while now.

I also sent a PM to Alex about a week ago, but the forums aren't actually showing anything in my "Sent Messages" list, so I sent him another one just this morning (worth noting: It still doesn't show anything in my "Sent Messages" list...)

Just trying to work things out so I can get my hands on this custom build mentioned by Alex.

djaydino

  • Administrator
  • Hero Member
  • *****
  • Posts: 7086
    • jinxtergames
Re: IndexOutOfRangeException when loading prefab containing PlayMaker FSM
« Reply #10 on: September 19, 2022, 05:06:03 AM »
Hi.
I will message him :)