playMaker

Author Topic: Get Child Action Tag problem and other Action Tag issues  (Read 1522 times)

djaydino

  • Administrator
  • Hero Member
  • *****
  • Posts: 2260
    • View Profile
    • jinxtergames
Get Child Action Tag problem and other Action Tag issues
« on: August 27, 2016, 03:29:03 PM »
Hi,
The Get Child Action Does not work as expected :

i have child objects with the same name but different tags used for something else so i tried to get them by setting "With Tag" to none but that did not work.
« Last Edit: October 16, 2016, 05:41:29 AM by djaydino »

jeanfabre

  • Administrator
  • Hero Member
  • *****
  • Posts: 12342
  • Official Playmaker Support
    • View Profile
Re: Get Child Action problem
« Reply #1 on: September 06, 2016, 12:05:45 AM »
Hi,

 odd. Can you make a quick repo scene, and I'll have a look and debug the code. Thanks :)

 Bye,

 Jean

djaydino

  • Administrator
  • Hero Member
  • *****
  • Posts: 2260
    • View Profile
    • jinxtergames
Re: Get Child Action problem
« Reply #2 on: September 06, 2016, 02:56:01 AM »
Hi,
It is very simple just make an object and place a child in it with a tag on it
the use get child, set the child name then on the with tag press the = to set to none.

But i just noticed when i press = again, it will show an empty bar and then it seems to work.
the script is not checking if the tag is null or empty and i made a solution already but i think this should be updated on the official action :)

jeanfabre

  • Administrator
  • Hero Member
  • *****
  • Posts: 12342
  • Official Playmaker Support
    • View Profile
Re: Get Child Action problem
« Reply #3 on: September 26, 2016, 01:46:24 AM »
Hi,

 I am not sure I follow actually :) can you make a screencast? I'd like to get to the bottom of this. If there is a problem, we need to fix it.

 Bye,

 Jean

djaydino

  • Administrator
  • Hero Member
  • *****
  • Posts: 2260
    • View Profile
    • jinxtergames
Re: Get Child Action problem
« Reply #4 on: September 26, 2016, 03:27:30 PM »
Hi,
I made a quick video :

(unity version 5.4.1f1 PM version 1.8.3f4)


jeanfabre

  • Administrator
  • Hero Member
  • *****
  • Posts: 12342
  • Official Playmaker Support
    • View Profile
Re: Get Child Action problem
« Reply #5 on: September 27, 2016, 12:22:18 AM »
Hi,

 yes I see. It's known misunderstanding.

Basically "untagged" means that no tag is set on the gameobject, it's not the same as allowing any tags, or to say this otherwise, ignoring tags all together. For this indeed set it to none or empty as you did.

It's tricky to change this right now as existing projects relies on this and so modifying this to ignore tags by default would corrupt existing projects.

Bye,

 Jean

djaydino

  • Administrator
  • Hero Member
  • *****
  • Posts: 2260
    • View Profile
    • jinxtergames
Re: Get Child Action problem
« Reply #6 on: September 27, 2016, 08:51:29 AM »
Hi,
Is this also the reason that when set to none sometimes works and sometimes not when playing around with the settings, like i did on the video?

jeanfabre

  • Administrator
  • Hero Member
  • *****
  • Posts: 12342
  • Official Playmaker Support
    • View Profile
Re: Get Child Action problem
« Reply #7 on: October 10, 2016, 02:23:57 AM »
Hi,

 the behaviour is consistent.

 "none" means that any tag can be on the gameobject
 "untagged" means that no tag must be on the gameobject

then depending on how you setup the action interface, you fall into one of the case above.

 Bye,

 Jean

djaydino

  • Administrator
  • Hero Member
  • *****
  • Posts: 2260
    • View Profile
    • jinxtergames
Re: Get Child Action problem
« Reply #8 on: October 10, 2016, 05:18:12 PM »
Hi,

Quote
"none" means that any tag can be on the gameobject

if you look closely to the video it does not find the child on the 1st time.

Then when i press the = again i get a blanco selection and then it works.

After that i did this and pressed the = again, then it works on 'none'

jeanfabre

  • Administrator
  • Hero Member
  • *****
  • Posts: 12342
  • Official Playmaker Support
    • View Profile
Re: Get Child Action problem
« Reply #9 on: October 11, 2016, 02:13:40 AM »
Hi,

 I see sorry, I know what's the problem now. I have fixed it. I'll see with Alex if it should make it in an update or stay as is, because it will potentially break existing projects

Thanks for your patience :)

 Bye,

 Jean



djaydino

  • Administrator
  • Hero Member
  • *****
  • Posts: 2260
    • View Profile
    • jinxtergames
Re: Get Child Action problem
« Reply #10 on: October 11, 2016, 06:14:26 AM »
Hi,
No problem.
I do think this should be changed, maybe with a big warning when updating :)

jeanfabre

  • Administrator
  • Hero Member
  • *****
  • Posts: 12342
  • Official Playmaker Support
    • View Profile
Re: Get Child Action problem
« Reply #11 on: October 13, 2016, 11:40:01 PM »
Hi,

 This is a serious bug indeed as it corrupts the logic 'none' should not return a previous value setup on that action, it should return an empty string.

Bye,

 Jean

djaydino

  • Administrator
  • Hero Member
  • *****
  • Posts: 2260
    • View Profile
    • jinxtergames
Re: Get Child Action Tag problem and other Action Tag issues
« Reply #12 on: October 16, 2016, 05:47:27 AM »
Hi,
I was testing something for someone on the forum and i found out that on the "Collision Event" Action the tag set to none or empty does not work at all.
Should i look on other actions and send a bug report in PM for each one i found with this problem?

jeanfabre

  • Administrator
  • Hero Member
  • *****
  • Posts: 12342
  • Official Playmaker Support
    • View Profile
Re: Get Child Action Tag problem and other Action Tag issues
« Reply #13 on: October 24, 2016, 11:03:56 PM »
Hi,

 yes if you can do this, that would be good, then we can do a batch update to fix them.

thanks,

 Bye,

 Jean